[tarantool-patches] Re: [PATCH 1/3] Add test on error during reconfigure
avkhatskevich at tarantool.org
Thu Jul 19 23:33:20 MSK 2018
>> +-- Check that data has at least all fields as an ethalon.
> 1. Typo here and in other places: ethalon -> etalon.
> 2. Please, describe the function in doxygen style since
> it is not a trival one-liner.
Added, however, the comment is bigger than the function...
>> +err:match('Error injection:.*')
> 3. P l e a s e. Again. Do not use pcall + match. Use
Ok. Sorry. It is a very old commit.
More information about the Tarantool-patches