[tarantool-patches] Re: [PATCH 2/4] Complete module reload

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Mon Jul 23 16:31:46 MSK 2018


Hi! Thanks for the patch!

> diff --git a/vshard/replicaset.lua b/vshard/replicaset.lua
> index 99f59aa..6c8d477 100644
> --- a/vshard/replicaset.lua
> +++ b/vshard/replicaset.lua
> @@ -21,6 +21,7 @@
>   --                                  requests to the replica>,
>   --             net_sequential_fail = <count of sequential failed
>   --                                    requests to the replica>,
> +--             is_outdated = nil/true,

https://github.com/tarantool/vshard/blob/kh/gh-112-reload-mt-2/vshard/replicaset.lua#L24

Looks like the version on the branch actually is outdated
instead of the replica object. Please, push the latest
version.

>   --          }
>   --      },
>   --      master = <master server from the array above>,
> @@ -34,6 +35,7 @@
>   --      etalon_bucket_count = <bucket count, that must be stored
>   --                             on this replicaset to reach the
>   --                             balance in a cluster>,
> +--      is_outdated = nil/true,
>   --  }
>   --
>   -- replicasets = {




More information about the Tarantool-patches mailing list