[tarantool-patches] Re: [PATCH v1 1/1] sql: show formated MsgPack BLOB on select

[n.pettik]

> Tnx. Ok for me, excluding this:
> 
> +++ b/src/box/sql/vdbeapi.c
> @@ -224,8 +224,7 @@ sqlite3_value_int64(sqlite3_value * pVal)
> enum sql_subtype
> sqlite3_value_subtype(sqlite3_value * pVal)
> {
> - Mem *pMem = (Mem *) pVal;
> - return (pMem->flags & MEM_Subtype) != 0 ? pMem->subtype : 0;
> + return (pVal->flags & MEM_Subtype) != 0 ? pVal->subtype : SQL_SUBTYPE_NO;
> }
> 
> on head "review review fixes"
> 
>> Nikita, please, look at my changes too, they are not minor.

I am OK with these fixes (and Kirill’s one too). Thanks.

*Nerd mode on*
However, I don’t stick to the point that introducing separate enum for
one subtype seems to be really vital.
*Nerd mode off*