[tarantool-patches] Re: [PATCH] sql: Remove 'BEGIN TRANSACTION'

Alexander Turenko alexander.turenko at tarantool.org
Mon Jul 9 18:35:31 MSK 2018

Hi Nikita!

I don't have objections against the patch, just two comments re tests.

It would be good to check a table content in the test to make sure a
transaction was executed as expected.

The new test failed in CI:


Please, ask next review from Nikita P.

WBR, Alexander Turenko.

On Thu, Jul 05, 2018 at 01:42:17PM +0300, N.Tatunov wrote:
> Patch is aimed on making our sql closer to ANSI sql.
> With the patch applied only following commands can be used:
>  - "START TRANSACTION" to begin transaction.
>  - "COMMIT" to end transaction.
>  - "ROLLBACK" to rollback transaction without savepoints.
>  - "ROLLBACK TO .." to rollback transaction to savepoint.
> Closes #2164
> ---
> Issue: https://github.com/tarantool/tarantool/issues/2164
> Branch: https://github.com/tarantool/tarantool/tree/N_Tatunov/gh-2164-remove-begin-transaction

More information about the Tarantool-patches mailing list