[tarantool-patches] Re: [PATCH v1 1/2] sql: use schema API to get index info in analyze

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Jul 25 23:52:21 MSK 2018


Hi! Thanks for the patch, but it is not needed anymore
after this commit
https://github.com/tarantool/tarantool/commit/0ecabde8981500886bf5be16cfabe4d1d1a33db4.

Moreover, we should stop use schema_find_id to get a space since
such requests should be filtered through _vspace to prevent
unauthorized access to _space. I've opened an issue:
https://github.com/tarantool/tarantool/issues/3570

On 24/07/2018 14:05, Kirill Shcherbatov wrote:
> We would like to avoid starting transactions in ANALYZE
> so we need to use schema API that is more tolerant.
> 
> Part of #3551.
> ---
>   src/box/sql/analyze.c | 82 ++++++++++++++++++++++++++++++---------------------
>   1 file changed, 48 insertions(+), 34 deletions(-)
> 




More information about the Tarantool-patches mailing list