[tarantool-patches] Re: [PATCH v1 0/2] sql: restrict nullable action definitions

[Vladislav Shpilevoy]

Thanks for the patchset! See 1 comments below.

On 12/07/2018 19:34, Kirill Shcherbatov wrote:
> This patch dissallows define multiple "NULL", "NOT NULL"

Typo.

> options per column and fixes silent implicit behavior
> for invalid "NULL PRIMARY KEY" construction.
> 
> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3473-on-conflict-defaults-fixes
> Issue: https://github.com/tarantool/tarantool/issues/3473
> 
> Kirill Shcherbatov (2):
>    sql: restrict nullable action definitions
>    sql: fixed possible leak in sqlite3EndTable
> 
>   src/box/alter.cc              |  1 +
>   src/box/field_def.c           |  1 +
>   src/box/field_def.h           |  3 ++-
>   src/box/sql/build.c           | 53 +++++++++++++++++++++++++++++++++++++------
>   src/box/sql/parse.y           |  2 +-
>   test/sql/on-conflict.result   | 13 +++++++++++
>   test/sql/on-conflict.test.lua |  6 +++++
>   7 files changed, 70 insertions(+), 9 deletions(-)
>