[tarantool-patches] Re: [PATCH v1 2/2] sql: prevent executing crossengine sql

Kirill Shcherbatov kshcherbatov at tarantool.org
Fri Jul 27 10:13:06 MSK 2018


> Thanks for the fixes! I have pushed my own on the branch.
> Please, squash.
> 
> Sorry, I was wrong about txn != NULL omitting. If we omit it,
> then for ephemeral spaces we do not start ro stmt, but commit
> it. It is not correct.
> 
> Your code works only because commit_ro() is no-op when we
> have an active transaction. But it can change in futureThank you for review. I've squashed this changes. 




More information about the Tarantool-patches mailing list