[patches] Re: [PATCH] Break connection on timeout

Konstantin Osipov kostja at tarantool.org
Sat Feb 10 09:46:55 MSK 2018

* Konstantin Belyavskiy <k.belyavskiy at tarantool.org> [18/02/09 15:32]:
> Option 1 (without new parameter but with error injection to pass test):
> https://github.com/tarantool/tarantool/commit/eeb4ed12938dca972e12cf1ac117641c75ff9ea7
> Option 2 (with new parameter disconnect_timeout and without error injection):
> https://github.com/tarantool/tarantool/commit/aa6b81c63b03e08981a1272fc31243f04debc230  

Both patches introduce the case when a misconfigured peer is constantly
disconnected. I think this creates a typical gotcha. 

> I personally think that second is better, that's why I send it to review first.
> But still it has one thing to discuss:
> For compatibility I bind by default replication_disconnect_timeout to disconnect_timeout,
> but probably it's better not do it. Because It has internal check that disconnect timeout is greater
> than replication timeout, if user do not change it, all instances will have same value, no matter
> that replication timeout value is used. So this will not break connection between different instances,
> and makes easier to connect with older versions.

Compatibility is less of a concern since users have been about
the current behaviour for years.

Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.org - www.twitter.com/kostja_osipov

More information about the Tarantool-patches mailing list