[patches] [PATCH 2/4] Move tuple_compare wrappers to key_def.h/.cc

[Konstantin Osipov]

* v.shpilevoy at tarantool.org <v.shpilevoy at tarantool.org> [18/02/17 23:36]:
> Ask Kostja about it. It is his idea.

Vladimir,

The single-line wrappers don't work without key_def. By putting
them to key_def.h we reduce the number of necessary includes. 
They don't belong to tuple_extract_key.h, because most of users of
tuple_extract_key.h don't use these wrappers (grep it). I see no
point in adding a separate file like "key_def_wrappers.h", hence a
single file.

> 
> С уважением, Владислав Шпилевой.
> 
> > 17 февр. 2018 г., в 21:52, Vladimir Davydov <vdavydov.dev at gmail.com> написал(а):
> > 
> >> On Tue, Feb 13, 2018 at 06:28:36PM +0300, Vladislav Shpilevoy wrote:
> >> They have no sense without key_def.h.
> > 
> > So what? If we followed this flawed logic, we ended up moving all source
> > code to a single file. If there's another reason why you cannot make
> > progress without it, please share, otherwise drop this patch.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.org - www.twitter.com/kostja_osipov