[patches] [PATCH 1/1] test: vinyl secondary idx iterator skips changes of read keys
kostja at tarantool.org
Tue Feb 20 19:11:45 MSK 2018
* Vladimir Davydov <vdavydov.dev at gmail.com> [18/02/17 11:57]:
> On Fri, Feb 16, 2018 at 06:59:07PM +0300, Vladislav Shpilevoy wrote:
> > If a key is updated after a secondary index scan, but before a
> > primary index lookup, then ignore this update.
> > Closes #2442
> Technically, the patch is fine, but I don't see any practical value in
> it, because behavior of SELECT in presense of secondary keys should
> already be checked by the vinyl/select_consistency test.
I have a habit (which begot a policy) to push test cases for
issues regardless of existing test coverage. I assume one can
change independently of the other in the future, and we need to be
able to quickly navigate from a ticket to a test, e.g. when
dealing with a duplicate ticket or tracking down a regression.
Perhaps it's a bad idea after all, we can discuss.
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.org - www.twitter.com/kostja_osipov
More information about the Tarantool-patches