[patches] [PATCH 2/3] sql: remove extra key copy from cursor routine

n.pettik korablev at tarantool.org
Mon Feb 12 20:00:57 MSK 2018


Not quite. They are still required when cursor_seek() routine is called via first()/last() functions.

> On 12 Feb 2018, at 19:20, Alex Khatskevich <avkhatskevich at tarantool.org> wrote:
> After your change, there is no need in key and key_end attributes any more.
> They are only confuse it's user.
> Am I right?
>> -	/* Copy key if necessary. */
>> -	if (key_size != 0) {
>> -		memcpy(c->key, key, key_end - key);
>> -		key_end = c->key + (key_end - key);
>> -		key = c->key;
>> -	}
>> -
>>  	struct space *space;
>>  	struct index *index;
>>  	uint32_t space_id = SQLITE_PAGENO_TO_SPACEID(pCur->pgnoRoot);

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20180212/1e0d37c3/attachment.html>


More information about the Tarantool-patches mailing list