[patches] Re: [PATCH] Break connection on timeout

[Konstantin Osipov]

* Konstantin Belyavskiy <k.belyavskiy at tarantool.org> [18/02/08 21:53]:
> 
> branch: gh-3025-break-connection-timeout-v2

I like the idea of disconnect timeout being separate from other
timeouts, since I'm really concerned with the case of bogus
disconnects in case of different heartbeat settings at master and
slave. 

I'm just brainstorming, but how about this:

- we pass time of the next heartbeat in each heartbeat message. 
  We can measure this time, instead of passing it on - e.g. by 
  keeping applier.prev_heartbeat_time or similar.
- unless we have reached (heartbeat time) *
  disconnect_heartbeat_count timeout without heartbeats, we don't
  disconnect. Initially, until we know prev_heartbeat_time Or we
  only disconnect after some hard-coded timeout
  like 300 seconds. And we never let to set heartbeat timeout
  above 60 seconds, so that the two options work well together.
- we disconnect only after we missed X heartbeats.

Other options?

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.org - www.twitter.com/kostja_osipov