[patches] Re: [PATCH] Fix force_recovery on empty xlog

[Konstantin Osipov]

Hi,

Did you run all tests ?

Your patch breaks xlog/empty.test.py, which explicitly tests the
old behaviour:

Vladimir, looks like you didn't run tests either before OKaying  :-(

Travis is also red for this branch, so if anyone ever cared to
look, you'd have noticed.


[001] xlog-py/empty.test.py                                           [ fail ]
[001] 
[001] Test failed! Result content mismatch:
[001] --- xlog-py/empty.result	Thu Aug 17 10:46:32 2017
[001] +++ xlog-py/empty.reject	Fri Feb  2 22:27:57 2018
[001] @@ -1,10 +1,10 @@
[001]  .xlog exists
[001]  _ = box.schema.space.create('test')
[001]  ---
[001] -- error: Failed to write to disk
[001]  ...
[001]  _ = box.schema.space.create('test')
[001]  ---
[001] +- error: Space 'test' already exists
[001]  ...
[001]  box.space.test:drop()

* Konstantin Belyavskiy <k.belyavskiy at tarantool.org> [18/01/31 19:07]:

<cut>

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.org - www.twitter.com/kostja_osipov