[patches] [PATCH v2 0/3] sql: fix identifier checks

AKhatskevich avkhatskevich at tarantool.org
Tue Feb 6 14:20:11 MSK 2018


Branch: kh/gh-2126-allow-identifiers

Changes in v2:
 - minor fixes in names and comments as per comments by kyukhin@

AKhatskevich (3):
  sql: do not uppercase system space names
  sql: check identifiers only for printability
  sql: make _sql_stat[14] to be a system spaces

 src/box/bootstrap.snap                             | Bin 1531 -> 1661 bytes
 src/box/lua/space.cc                               |   4 +
 src/box/lua/upgrade.lua                            |  34 ++++++
 src/box/schema_def.h                               |   3 +
 src/box/sql.c                                      |  70 +++++++++----
 src/box/sql/alter.c                                |  30 ------
 src/box/sql/analyze.c                              |  81 ++++++---------
 src/box/sql/build.c                                | 107 ++++++++++---------
 src/box/sql/delete.c                               |  10 +-
 src/box/sql/expr.c                                 |   3 +
 src/box/sql/sqliteInt.h                            |   6 +-
 src/box/sql/tarantoolInt.h                         |  16 +--
 src/box/sql/trigger.c                              |  11 +-
 test/app-tap/tarantoolctl.test.lua                 |   4 +-
 test/box-py/bootstrap.result                       |  11 +-
 test/box/access_misc.result                        |   6 ++
 test/box/access_sysview.result                     |   6 +-
 test/box/alter.result                              |   7 +-
 test/sql-tap/alter.test.lua                        |  32 +++---
 test/sql-tap/analyze1.test.lua                     |  91 +++++++---------
 test/sql-tap/analyze3.test.lua                     |   2 +-
 test/sql-tap/analyze4.test.lua                     |  13 ++-
 test/sql-tap/analyze5.test.lua                     |  12 ++-
 test/sql-tap/analyze9.test.lua                     |  84 ++++++++-------
 test/sql-tap/analyzeC.test.lua                     |  32 +++---
 test/sql-tap/analyzeD.test.lua                     |   4 +-
 test/sql-tap/autoinc.test.lua                      |  17 +--
 test/sql-tap/gh-2723-concurrency.test.lua          |   4 +-
 test/sql-tap/identifier-characters.test.lua        | 108 +++++++++++++++++++
 test/sql-tap/index1.test.lua                       | 114 +++++++++------------
 test/sql-tap/intpkey.test.lua                      |   3 +-
 test/sql-tap/select9.test.lua                      |   4 +-
 test/sql-tap/selectA.test.lua                      |   2 +-
 test/sql-tap/suite.ini                             |   2 +-
 test/sql-tap/table.test.lua                        |  10 +-
 test/sql-tap/trigger1.test.lua                     |   8 +-
 test/sql/gh2141-delete-trigger-drop-table.result   |   4 +-
 test/sql/gh2141-delete-trigger-drop-table.test.lua |   4 +-
 test/sql/persistency.result                        |   8 +-
 test/sql/persistency.test.lua                      |   8 +-
 test/wal_off/alter.result                          |   2 +-
 test/xlog/upgrade.result                           |  11 +-
 42 files changed, 553 insertions(+), 435 deletions(-)
 create mode 100755 test/sql-tap/identifier-characters.test.lua

-- 
2.14.1




More information about the Tarantool-patches mailing list