[PATCH] replication: fix disconnect due to race condition

Konstantin Belyavskiy k.belyavskiy at tarantool.org
Thu Feb 15 19:38:06 MSK 2018


Incomming ACK lead to race condition and prevent heartbeat
messages. It ends up with disconnect on timeout.
Try to fix this behaviour, by changing wake conditions.

Fix #3160
---
branch: gh-3160-disconnect-race-condition
 src/box/relay.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/box/relay.cc b/src/box/relay.cc
index f9f22d622..cb3e1148d 100644
--- a/src/box/relay.cc
+++ b/src/box/relay.cc
@@ -366,7 +366,6 @@ relay_reader_f(va_list ap)
 			/* vclock is followed while decoding, zeroing it. */
 			vclock_create(&relay->recv_vclock);
 			xrow_decode_vclock_xc(&xrow, &relay->recv_vclock);
-			fiber_cond_signal(&relay->reader_cond);
 		}
 	} catch (Exception *e) {
 		if (diag_is_empty(&relay->diag)) {
-- 
2.14.3 (Apple Git-98)




More information about the Tarantool-patches mailing list