[patches] [PATCH 1/1] vinyl: introduce vy_run_writer

Vladimir Davydov vdavydov.dev at gmail.com
Sat Feb 17 12:08:18 MSK 2018


On Sat, Feb 10, 2018 at 02:12:29AM +0300, Vladislav Shpilevoy wrote:
> Vy_run_writer incapsulates logic of writing statements to a run.
> It provides API to write statements one by one.
> 
> It is needed for #2129, where primary index dump, compaction, coalesce
> and split generates one run for primary index and one run for each
> secondary index.
> 
> In such a case task_..._execute() function must write into multiple
> runs sequentially.
> 
> Signed-off-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
> ---
>  src/box/vy_run.c            | 520 +++++++++++++++++++++++---------------------
>  src/box/vy_run.h            |  94 +++++++-
>  src/box/vy_scheduler.c      |  18 +-
>  src/box/xlog.c              |   2 +-
>  src/box/xlog.h              |   5 +-
>  test/unit/vy_point_lookup.c |  10 +-
>  6 files changed, 374 insertions(+), 275 deletions(-)

Without the optimization #2129, this patch is pointless. It only bloats
the code judging by git stats above. Committing it to vinyl, which is
currently more-or-less stable, would be imprudent. Let's postpone it
until we see the whole series and some test results.



More information about the Tarantool-patches mailing list