[tarantool-patches] Re: [PATCH 0/2 v2] fio: show function name in all fio errors

Alexander Turenko alexander.turenko at tarantool.org
Sat Dec 8 17:36:09 MSK 2018


On Sat, Dec 08, 2018 at 04:41:08PM +0300, roman wrote:
> 
> Hi! Thanks for review.
> > I think within scope of this issue we should only add function names
> > into error messages and add path part number, but remove the second
> > parameter of the error() function where it is used across the fio
> > module.
> 
> Removed.

Now the code looks good to me.

But commit messages (of both commits) now do not reflect code changes.
Please, squash commits and fix the commit message.

WBR, Alexander Turenko.



More information about the Tarantool-patches mailing list