[tarantool-patches] Re: [PATCH 2/4] iproto: fire on_disconnect right after disconnect

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Dec 11 15:55:06 MSK 2018



On 07/12/2018 20:37, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [18/12/07 18:48]:
>> Before the patch on_disconnect triggers were called
>> only after last outstanding request had finished. It
>> was enough for most goals. But after box.session.push
>> was implemented, it appeared that it is impossible to
>> return an error from push() if a connection is closed.
>>
>> Tx session just does not know that a connection is
>> already closed. The patch splits destroy and
>> disconnect phases of an iproto connection lifecycle.
>> Disconnect calls on_disconnect triggers and resets
>> iproto socket fd. Destroy frees resources.
> 
> OK to push.
> 
>> Needed for #3859
>   
> 

Pushed to 2.1 and 1.10.



More information about the Tarantool-patches mailing list