[tarantool-patches] Re: [PATCH] sql: increment VIEW counter for tables within sub-select

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Mon Dec 3 19:19:40 MSK 2018


Hi! Thanks for the patch!

The patch is ok, but please, apply this
diff:

diff --git a/src/box/alter.cc b/src/box/alter.cc
index eca217511..03ba68adc 100644
--- a/src/box/alter.cc
+++ b/src/box/alter.cc
@@ -1515,8 +1515,8 @@ update_view_references(struct Select *select, int update_value,
  		uint32_t space_id;
  		if (schema_find_id(BOX_SPACE_ID, 2, space_name,
  				   strlen(space_name), &space_id) != 0) {
-				sqlite3SrcListDelete(sql_get(), list);
-				return -1;
+			sqlite3SrcListDelete(sql_get(), list);
+			return -1;
  		}
  		if (space_id == BOX_ID_NIL) {
  			if (! suppress_error) {


After it the patch LGTM.




More information about the Tarantool-patches mailing list