[tarantool-patches] [PATCH 01/11] box: move info_handler interface into src/info

[Konstantin Osipov]

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [18/11/30 18:41]:
> @@ -30,10 +30,10 @@
>   */
>  #include "box/lua/index.h"
>  #include "lua/utils.h"
> +#include "lua/info.h"
> +#include <info.h>

Please prefer local headers whenever you can ("" rather than <>).
Your host platform can have a header file info.h at a system-wide
location. It's easy if it simply breaks your compile in a funny
way. Worse if it doesn't break.

> +++ b/src/box/lua/info.c
> @@ -32,7 +32,7 @@
>  #define _GNU_SOURCE
>  #endif

Since you are up to cleaning things up a bit, please get rid of
file-local _GNU_SOURCE. It should be part of cmake compile flags
for this file. 


Otherwise the patch is OK to push.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov