[tarantool-patches] Re: [PATCH v2 1/6] sql: remove unnecessary macros from pragma.*

[n.pettik]

Nit: at the end of commit subject redundant ‘*’ and dot.

> On 15 Dec 2018, at 13:54, imeevma at tarantool.org wrote:
> 
> Some of the macros used in pragma.c and pragma.h are obsolete
> because the values they checked were deleted.

They weren’t deleted, they are simply not used.
I guess they still can be enabled, if add appropriate commands
to cmake lists. On the other hand, I doubt that someday we
really may need them.

> Part of #3832

In fact, this commit has nothing in common with mentioned issue.

> -#if !defined(SQLITE_OMIT_FLAG_PRAGMAS)
> 	{ /* zName:     */ "query_only",
> 	 /* ePragTyp:  */ PragTyp_FLAG,
> 	 /* ePragFlg:  */ PragFlg_Result0 | PragFlg_NoColumns1,
> @@ -168,28 +157,23 @@ static const PragmaName aPragmaName[] = {
> 	 /* ePragFlg:  */ PragFlg_Result0 | PragFlg_NoColumns1,
> 	 /* ColNames:  */ 0, 0,
> 	 /* iArg:      */ SQLITE_RecTriggers},
> -#endif
> -#if !defined(SQLITE_OMIT_FLAG_PRAGMAS)
> 	{ /* zName:     */ "reverse_unordered_selects",
> 	 /* ePragTyp:  */ PragTyp_FLAG,
> 	 /* ePragFlg:  */ PragFlg_Result0 | PragFlg_NoColumns1,
> 	 /* ColNames:  */ 0, 0,
> 	 /* iArg:      */ SQLITE_ReverseOrder},
> -#endif
> -#if !defined(SQLITE_OMIT_FLAG_PRAGMAS) && defined(SQLITE_ENABLE_SELECTTRACE)
> +#if defined(SQLITE_ENABLE_SELECTTRACE)

Why didn’t you remove ENABLE_SELECTTRACE as well?

> @@ -254,8 +231,7 @@ static const PragmaName aPragmaName[] = {
> 	 /* ColNames:  */ 0, 0,
> 	 /* iArg:      */ SQLITE_VdbeTrace},
> #endif
> -#endif
> -#if !defined(SQLITE_OMIT_FLAG_PRAGMAS) && defined(SQLITE_ENABLE_WHERETRACE)
> +#if defined(SQLITE_ENABLE_WHERETRACE)

The same question.