[tarantool-patches] Re: [PATCH 0/4] Outdate disconnected session

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Dec 11 19:12:37 MSK 2018



On 07/12/2018 20:35, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [18/12/07 18:48]:
>> Once a connection is closed, a long-running user request can not
>> learn about this occasion. Even box.sesion.push() still works and
>> on_disconnect triggers are not run.
>>
>> This patch makes things simpler:
>>
>> * disconnected session is marked as dead. So a user can determine
>>    if a connection is closed by looking at session type == 'dead',
>>    or checking for errors from box.session.push();
> 
> 'dead' is not a session type, it's session state. Please add a
> separate method for this purpose, and not abuse the type.

Done. See v2.

>>
>> * on_disconnect triggers are run right after disconnect. Even if
>>    there are some active requests.
> 
> This is an incompatible change. But people have been actually
> complaining in the chat that disconnect triggers are only run
> after all messages are processed. So a good one.
> 
> 



More information about the Tarantool-patches mailing list