[tarantool-patches] Re: [PATCH v2 4/5] sql: encode tuples with mpstream on Vdbe run

[Kirill Shcherbatov]

Hi! Thank you for review.
> Nit: ... and table has other records.
> It is russian-like collocation, we can’t ‘make’ lookup.
> "… Vdbe inspects parent table emitting OP_Found" (or smth like this) 
> Nit: must.
> Nit: got rid of.
> Nit: not NULL … or simply “Pointer to valid tuple."
Fixed. Here and in previous patch.

> Lets replace these if-else's with one switch.
Unfortunately, it is not possible now, as we may have a flag combination
(like OP_String+OP_Blob). You may take a look into Server chat for more
details for this particular case, but it is not the one.
Maybe we may improve it in future(when affinity would be reworked?) but
not now and not as a part of this patch, I believe.

> The rest is OK