[tarantool-patches] Re: [PATCH] sql: increment VIEW counter for tables within sub-select

Kirill Yukhin kyukhin at tarantool.org
Fri Dec 14 13:34:31 MSK 2018


Hello,
On 03 Dec 18:00, Nikita Pettik wrote:
> VIEW can be created not only in form of AS SELECT but also in form of AS
> VALUES (...). In the latter case space's view reference counters were
> not incremented. Furthermore, if view came with sub-select, reference
> counters of tables within sub-select were not updated as well. These
> problems occurred due to simplified traverse over AST: only tables
> within FROM clause were accounted. This patch fixes them introducing
> complete pass over AST using walker.
> 
> Closes #3815
> ---
> Branch: https://github.com/tarantool/tarantool/commits/np/gh-3815-drop-view-as-values
> Issue: https://github.com/tarantool/tarantool/issues/3815

I've checked your patch into 2.1 branch.

--
Regards, Kirill Yukhin




More information about the Tarantool-patches mailing list