[tarantool-patches] Re: [PATCH 1/2] sql: add CHAR description without length
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Mon Dec 3 16:48:51 MSK 2018
Hi! Thanks for the patch!
Please, sending a patchset consisting from multiple
commits send a cover-letter too. Branch and Issue
links should be there.
No cover-letter is ok only for single-commit patches.
Talking about functional part - it is ok. But I've
pushed one preparation patch before your:
commit 7c0ef3cc962ce5724485b18c0da014625920bf3e
Author: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
Date: Mon Dec 3 16:16:51 2018 +0300
sql: store CHAR|VARCHAR len as integer, not type_def
Please, send all the 3 commits as v2 thread to Nikita for
a second review.
More information about the Tarantool-patches
mailing list