[tarantool-patches] Re: [PATCH v5 3/9] box: manage format fields with JSON tree class

[Vladimir Davydov]

On Tue, Dec 04, 2018 at 06:47:16PM +0300, Kirill Shcherbatov wrote:
> As we going to work with format fields in a unified way, we
> started to use the tree JSON class for working with first-level
> format fields.
> 
> Need for #1012
> ---
>  src/box/sql.c          |  16 +++---
>  src/box/sql/build.c    |   5 +-
>  src/box/tuple.c        |  10 ++--
>  src/box/tuple_format.c | 125 +++++++++++++++++++++++++++++------------
>  src/box/tuple_format.h |  49 +++++++++++++---
>  src/box/vy_stmt.c      |   4 +-
>  6 files changed, 150 insertions(+), 59 deletions(-)

This patch doesn't compile on my laptop. Please fix.

In file included from /home/vlad/src/tarantool/src/box/tuple.h:38:0,
                 from /home/vlad/src/tarantool/src/box/tuple_compare.h:38,
                 from /home/vlad/src/tarantool/src/box/tuple_compare.cc:31:
/home/vlad/src/tarantool/src/box/tuple_format.h: In function ‘tuple_field* tuple_format_field(tuple_format*, uint32_t)’:
/home/vlad/src/tarantool/src/box/tuple_format.h:207:2: sorry, unimplemented: non-trivial designated initializers not supported
  };
  ^
/home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::hash’ [-Werror=missing-field-initializers]
/home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::children’ [-Werror=missing-field-initializers]
/home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::child_count_max’ [-Werror=missing-field-initializers]
/home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::child_count’ [-Werror=missing-field-initializers]
/home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::sibling_idx’ [-Werror=missing-field-initializers]
/home/vlad/src/tarantool/src/box/tuple_format.h:207:2: error: missing initializer for member ‘json_token::parent’ [-Werror=missing-field-initializers]
At global scope:
cc1plus: error: unrecognized command line option ‘-Wno-cast-function-type’ [-Werror]
cc1plus: error: unrecognized command line option ‘-Wno-format-truncation’ [-Werror]
cc1plus: all warnings being treated as errors