[tarantool-patches] Re: [PATCH 01/11] box: move info_handler interface into src/info

Vladimir Davydov vdavydov.dev at gmail.com
Tue Dec 4 11:52:14 MSK 2018


On Tue, Dec 04, 2018 at 12:48:25AM +0300, Vladislav Shpilevoy wrote:
> > > +++ b/src/box/lua/info.c
> > > @@ -32,7 +32,7 @@
> > >   #define _GNU_SOURCE
> > >   #endif
> > 
> > Since you are up to cleaning things up a bit, please get rid of
> > file-local _GNU_SOURCE. It should be part of cmake compile flags
> > for this file.
> 
> Unfortunately, Vova required to remove all my cleanup so
> I can not remove _GNU_SOURCE in scope of this patch, sorry.

Don't be ridiculous. Removing a stale definition along the way would be
fine with me. I detested the way you reformatted comments and refactored
the code for no apparent reason. I squashed removal of this pointless
_GNU_SOURCE into your patch before merging it.



More information about the Tarantool-patches mailing list