[tarantool-patches] Re: [PATCH v2 5/5] sql: do not use OP_Delete+OP_Insert for UPDATES

[n.pettik]

> 
> +/** Callback to forward and error from mpstream methods. */
> +static inline void
> +mpstream_encode_error(void *error_ctx)
> +{
> +	*(bool *)error_ctx = true;
> +}

Is this artefact after previous patch?

> +/**
> + * Perform encoding memory variable to stream.
> + * @param stream Initialized mpstream encoder object.
> + * @param var Vdbe memory variable to encode with stream.
> + */
> +void
> +mpstream_encode_vdbe_mem(struct mpstream *stream, struct Mem *var);
> +

The same question.

The rest is Ok now.

I didn’t carefully check test fixes tho, only looked through, since they
consist of monotonic changes, but I believe you did it :)