[tarantool-patches] Re: [PATCH 2/6] sql: don't update SQL string during renaming

[n.pettik]

> On 10 Dec 2018, at 17:16, Vladislav Shpilevoy <v.shpilevoy at tarantool.org> wrote:
> 
> Thanks for the patch!
> 
> On 10/12/2018 00:30, Nikita Pettik wrote:
>> Since SQL string containing "CREATE TABLE ..." statement is not used
>> anymore for ordinary tables/space, it makes no sense to modify it during
>> renaming. Hence, now rename routine needs only to update name in _space,
>> so it can be done using simple update operation.
>> Moreover, now we are able to rename spaces created from Lua-land.
>> Part of #2647
>> ---
>>  src/box/sql.c               | 187 ++++++++------------------------------------
>>  src/box/sql/tarantoolInt.h  |   3 +-
>>  src/box/sql/vdbe.c          |   4 +-
>>  test/sql-tap/alter.test.lua |  32 +++++++-
>>  4 files changed, 63 insertions(+), 163 deletions(-)
> 
> You forgot to remove some code and comments. My
> review fixes here and on the branch.

Thx, applied.