[tarantool-patches] Re: [PATCH v5 3/9] box: manage format fields with JSON tree class

Vladimir Davydov vdavydov.dev at gmail.com
Thu Dec 6 11:06:26 MSK 2018


On Thu, Dec 06, 2018 at 10:56:55AM +0300, Kirill Shcherbatov wrote:
> As we going to work with format fields in a unified way, we
> started to use the tree JSON class for working with first-level
> format fields.
> 
> Needed for #1012
> ---
>  src/box/sql.c          |  18 +++---
>  src/box/sql/build.c    |   5 +-
>  src/box/tuple.c        |  10 ++--
>  src/box/tuple_format.c | 122 +++++++++++++++++++++++++++++------------
>  src/box/tuple_format.h |  49 ++++++++++++++---
>  src/box/vy_stmt.c      |   4 +-
>  6 files changed, 148 insertions(+), 60 deletions(-)

I don't understand what have changed and why you have to resend this
patch. Please push the patches you think are ready to a separate branch
and resend them as a separate thread. And please write a change log
describing briefly what have changed since the last version.



More information about the Tarantool-patches mailing list