[tarantool-patches] Re: [PATCH 0/3 v2] sql: add test for indexed char in sub subquery
roman
roman.habibov at tarantool.org
Sat Dec 8 19:49:59 MSK 2018
Hi! Thanks for review.
>> It is not needed for #3616 - this commit and issue are not connected.
>> Issue disappeared after static types were introduced. It is ok that
>> you added test case on this issue, but these two problems are not related.
Removed.
> Consider refactoring:
>
> diff --git a/src/box/sql/parse.y b/src/box/sql/parse.y
> index f5e86fba1..d56fce451 100644
> --- a/src/box/sql/parse.y
> +++ b/src/box/sql/parse.y
> @@ -1485,26 +1485,22 @@ typedef(A) ::= DATE . { A.type = AFFINITY_REAL; }
> typedef(A) ::= TIME . { A.type = AFFINITY_REAL; }
> typedef(A) ::= DATETIME . { A.type = AFFINITY_REAL; }
>
> -%type char_len {int}
> -typedef(A) ::= CHAR char_len(B) . {
> +typedef(A) ::= CHAR . {
> A.type = AFFINITY_TEXT;
> - (void) B;
> }
>
> -%type vchar_len {int}
> -typedef(A) ::= VARCHAR vchar_len(B) . {
> - A.type = AFFINITY_TEXT;
> +char_len(A) ::= LP INTEGER(B) RP . {
> + (void) A;
> (void) B;
> }
>
> -char_len(A) ::= . {
> - (void) A;
> +typedef(A) ::= CHAR char_len(B) . {
> + A.type = AFFINITY_TEXT;
> + (void) B;
> }
>
> -char_len(A) ::= vchar_len(A) .
> -
> -vchar_len(A) ::= LP INTEGER(B) RP . {
> - (void) A;
> +typedef(A) ::= VARCHAR char_len(B) . {
> + A.type = AFFINITY_TEXT;
> (void) B;
> }
>
> In this case code looks a bit more straightforward IMHO.
Refactored.
>>> sql: add test for indexed char in sub subquery
> You don’t need to drop and re-create table t2 -
> it doesn’t change in half cases. You should drop it
> only when you change format of table, but in other
> cases it doesn’t affect anything.
Fixed.
More information about the Tarantool-patches
mailing list