[tarantool-patches] Re: [PATCH v1 1/1] sql: Fix DEFAULTs AST memory leak on alter
Kirill Yukhin
kyukhin at tarantool.org
Tue Dec 25 16:29:59 MSK 2018
Hello,
On 25 Dec 15:00, Kirill Shcherbatov wrote:
> The space_def_destroy_fields routine is used in make_scoped_guard
> on alter:space_def_new_from_tuple always pass extern_alloc=true
> for sql_expr_delete routine. It shouldn't as the first-time
> allocated AST (field_def_decode) is not external-allocated.
> Introduced a new flag 'extern_alloc' for space_def_destroy_fields
> routine.
>
> Closes #3908
>
> http://github.com/tarantool/tarantool/tree/kshch/gh-3908-fix-ast-alter-memleak
> https://github.com/tarantool/tarantool/issues/3908
I've committed your patch into 2.1 branch.
--
Regards, Kirill Yukhin
More information about the Tarantool-patches
mailing list