[tarantool-patches] Re: [PATCH v2 1/1] sql: support HAVING without GROUP BY clause

[Vladislav Shpilevoy]

Hi! Thanks for the fixes!

On 04/12/2018 13:44, Kirill Shcherbatov wrote:
> Hi! Thank you for comments:
>> 1. Please, add an example and a reference to a standard (I've
>> found more strict description in 2011 SQL standard
>> "Part 2: Foundation" on 403 page).
> Appended to the end of @TarantoolBot document:
> 
>    2011 SQL standard "Part 2: Foundation" 7.10 <having clause> p.381
>          Example:
>      SELECT MIN(s1) FROM te40 HAVING SUM(s1) > 0; -- is valid
>      SELECT 1 FROM te40 HAVING SUM(s1) > 0;       -- is valid
>      SELECT NULL FROM te40 HAVING SUM(s1) > 0;    -- is valid
>      SELECT date() FROM te40 HAVING SUM(s1) > 0;  -- is valid
> 
>> 2. Why do you need sql_expr_is_literal() and sql_expr_is_constant_func()
>> if you have sqlite3ExprIsConstantOrFunction() ?
> Yep, good idea; didn't know that such function already exists
> 

On the branch I still see my commit with review fixes and
your old implementation. Please, push a new version.