[tarantool-patches] Re: [PATCH v2 5/5] sql: do not use OP_Delete+OP_Insert for UPDATES

[Kirill Shcherbatov]

>> +/** Callback to forward and error from mpstream methods. */
>> +static inline void
>> +mpstream_encode_error(void *error_ctx)
>> +{
>> +	*(bool *)error_ctx = true;
>> +}
> 
> Is this artefact after previous patch?
Ugum, it was already fixed on branch.


>> +void
>> +mpstream_encode_vdbe_mem(struct mpstream *stream, struct Mem *var);
>> +
> The same question.
Here I did it consciously. This routine was just a helper in previous patch so may be
static that likelly doesn't require function call by pointer. In this patch it became
reusable so I have to define it's signature in header.
But I've already moved this change to previous path to decrease changes. It doesn't
really matter.

> The rest is Ok now.
> I didn’t carefully check test fixes tho, only looked through, since they
> consist of monotonic changes, but I believe you did it :)