[PATCH v2 04/10] box: don't use box_checkpoint_is_in_progress outside box.cc
Konstantin Osipov
kostja at tarantool.org
Sun Dec 9 00:43:45 MSK 2018
* Vladimir Davydov <vdavydov.dev at gmail.com> [18/12/09 00:15]:
> We only use box_checkpoint_is_in_progress in SIGUSR1 signal handler to
> print a warning in case checkpointing cannot be started, because it's
> already done by another fiber. Actually, it's not necessary to use it
> there - instead we can simply log the error returned by box_checkpoint,
> which will be self-explaining ER_CHECKPOINT_IN_PROGRESS in this case.
> So let's make box_checkpoint_is_in_progress private to box.cc - this
> will simplify moving the checkpoint daemon to the gc module.
OK to push.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
More information about the Tarantool-patches
mailing list