[tarantool-patches] Re: [PATCH 08/10] sql: use secondary indexes to process OP_Delete

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Mon Aug 13 23:24:27 MSK 2018


Thanks for the patch! I have pushed my review fixes in
a separate commit.

On 12/08/2018 17:13, Nikita Pettik wrote:
> Before this patch OP_Delete used only primary index to delete entry.
> Since it already operates on cursor, which in turn can be open on
> secondary index, lets pass index id to internal routine to use it.
> This is required in order to remove duplicates from secondary indexes
> while processing INSERT/UPDATE OR REPLACE statement.
> ---
>   src/box/sql.c              | 17 +++++------------
>   src/box/sql/tarantoolInt.h | 16 +++++++++++++++-
>   src/box/sql/vdbe.c         |  2 +-
>   3 files changed, 21 insertions(+), 14 deletions(-)
> 




More information about the Tarantool-patches mailing list