[PATCH 11/18] vinyl: use snap_io_rate_limit for initial dump bandwidth estimate

Konstantin Osipov kostja at tarantool.org
Mon Aug 20 14:24:31 MSK 2018


* Vladimir Davydov <vdavydov.dev at gmail.com> [18/08/16 23:03]:
> The user can limit dump bandwidth with box.cfg.snap_io_rate_limit to a
> value, which is less than the current estimate. To avoid stalls caused
> by overestimating dump bandwidth, we must take into account the limit
> for the initial guess and forget all observations whenever it changes.

>  void
> +vy_quota_reset_dump_bw(struct vy_quota *q, size_t max)
> +{
> +	histogram_reset(q->dump_bw_hist);
> +	q->dump_bw = MIN(VY_DEFAULT_DUMP_BANDWIDTH, max);
> +}
> +

This sounds like vy_quota_set_dump_bw to me, not reset().

Otherwise OK to push.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list