[tarantool-patches] Re: [PATCH 07/10] sql: remove index type from struct Index

[Vladislav Shpilevoy]

Thanks for the patch! I have pushed my review fixes in
a separate commit.

The most significant change - I have inlined sql_index_is_unique
since index's is_unique flag is intuitive enough to understand
what is being checked.

Also I have reduced primary index getting to just returning
of the first index in pTable->pIndex list like it is done in
struct space. And this patch passes the tests. But next started
failing. Please, investigate why. Looks like you started
inserting primary index not in the list head.

On 12/08/2018 17:13, Nikita Pettik wrote:
> Part of #3561
> ---
>   src/box/sql.c           |  2 +-
>   src/box/sql/analyze.c   |  2 +-
>   src/box/sql/build.c     | 92 +++++++++++++++++++------------------------------
>   src/box/sql/insert.c    | 14 ++++----
>   src/box/sql/pragma.c    |  7 +---
>   src/box/sql/prepare.c   |  9 +----
>   src/box/sql/sqliteInt.h | 18 ++++------
>   src/box/sql/update.c    |  2 +-
>   src/box/sql/where.c     |  4 +--
>   src/box/sql/wherecode.c |  4 +--
>   10 files changed, 58 insertions(+), 96 deletions(-)
>