[tarantool-patches] Re: [PATCH 06/10] sql: completely remove support of partial indexes

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Mon Aug 13 23:24:29 MSK 2018


Thanks for the patch! I have pushed my review fixes in
a separate commit.

Please, investigate also is it possible to remove pPartial
variable from constructAutomaticIndex? It would allow to
remove sql_resolve_part_idx_label alongside.

On 12/08/2018 17:13, Nikita Pettik wrote:
> We banned opportunity to create partial indexes long ago, but internal
> routine implementing this feature still remains. This patch completely
> removes it.
> 
> Part of #3561
> ---
>   src/box/sql/build.c     | 23 ++++++-----------------
>   src/box/sql/delete.c    | 17 +++--------------
>   src/box/sql/insert.c    | 12 ------------
>   src/box/sql/parse.y     |  6 +++---
>   src/box/sql/pragma.c    |  5 +----
>   src/box/sql/sqliteInt.h |  7 ++-----
>   src/box/sql/update.c    |  2 +-
>   src/box/sql/where.c     | 31 -------------------------------
>   8 files changed, 16 insertions(+), 87 deletions(-)
> 




More information about the Tarantool-patches mailing list