[tarantool-patches] Re: [PATCH 07/10] sql: remove index type from struct Index

[n.pettik]

> On 13 Aug 2018, at 23:24, Vladislav Shpilevoy <v.shpilevoy at tarantool.org> wrote:
> 
> Thanks for the patch! I have pushed my review fixes in
> a separate commit.
> 
> The most significant change - I have inlined sql_index_is_unique
> since index's is_unique flag is intuitive enough to understand
> what is being checked.
> 
> Also I have reduced primary index getting to just returning
> of the first index in pTable->pIndex list like it is done in
> struct space. And this patch passes the tests.

Actually, tests fail within this patch. I don’t think that
this fix worth investigation: I have already removed struct Index
and now hold indexes in table->space->index and always get
PK as table->space->index[0]. Patch is on its way.

> But next started
> failing. Please, investigate why. Looks like you started
> inserting primary index not in the list head.