[tarantool-patches] Re: [PATCH 04/10] sql: remove flags from struct Table

[Vladislav Shpilevoy]

Thanks for the patch! I have pushed my review fixes in
a separate commit.

On 12/08/2018 17:13, Nikita Pettik wrote:
> Check on flag TF_HasPrimaryKey replaced with simple PK lookup in the
> list of table indexes.
> Check on flag TF_Ephemeral replaced with table->def->id == 0.
> Check on flag TF_Autoincrement replaced with table->iAutoinc >= 0.
> 
> Part of #3561
> ---
>   src/box/sql/build.c     | 11 ++++-------
>   src/box/sql/insert.c    | 12 ++++--------
>   src/box/sql/select.c    |  4 +---
>   src/box/sql/sqliteInt.h |  8 --------
>   src/box/sql/where.c     |  3 +--
>   5 files changed, 10 insertions(+), 28 deletions(-)
>