[PATCH v2 2/7] vinyl: teach write iterator to return overwritten tuples

Konstantin Osipov kostja at tarantool.org
Tue Aug 21 18:14:57 MSK 2018


* Vladimir Davydov <vdavydov.dev at gmail.com> [18/08/21 15:19]:
>  	/*
> +	 * Deferred DELETE statements can only be produced by
> +	 * primary index compaction.
> +	 */
> +	assert(is_primary || handler == NULL);
> +	/*

With this assert, do you really need this check:

> +static int
> +vy_write_iterator_deferred_delete(struct vy_write_iterator *stream,
> +				  struct tuple *stmt)
> +{
> +	if (!stream->is_primary)
> +		return 0;

?

Otherwise lgtm.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list