[tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool

n.pettik korablev at tarantool.org
Fri Aug 17 11:49:40 MSK 2018


> On 17 Aug 2018, at 11:25, Alex Khatskevich <avkhatskevich at tarantool.org> wrote:
> 
> Do not split error messages at the middle of a sentence. It makes errors ungreppable.
> Make it <80 somehow different.

I guess this is extremely specific nitpicking: look at src/box/alter.cc: 
through the code there are a lot of breaks of error messages like:

alter.c : 405

tnt_raise(ClientError, errcode, tt_cstr(space_name, name_len),
         tt_sprintf("field %d has conflicting nullability and "
                   "nullable action properties", fieldno +
                   TUPLE_INDEX_BASE));

alter.cc : 524

if (exact_field_count != 0 &&
    exact_field_count < field_count) {
       tnt_raise(ClientError, errcode, tt_cstr(name, name_len),
                "exact_field_count must be either 0 or >= "\
                "formatted field count”);

etc






More information about the Tarantool-patches mailing list