[tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool

[Nikita Tatunov]

Hello! Please, consider my note.

> On 17 Aug 2018, at 11:25, Alex Khatskevich <avkhatskevich at tarantool.org> wrote:
> 
> 
> 
> On 16.08.2018 20:00, N.Tatunov wrote:
>> GLOB is a legacy extension for LIKE from SQLite. As we want our SQL to
>> be close to ANSI SQL & LIKE to depend on collations, we do not want to
>> support it. This patch totally removes it from Tarantool along with any
>> mentions of it.
> 1.We delete it because it is not working properly, and instead of fixing it we
> want to replace it with more general regexp. Delete other unnecessary thoughts
> from this message.
> 2. Do not use "we", "our" in commit messages.

I can’t agree with the first note. I’m not sure if we can call it a “replacement”.
Firstly we have long been having a ticket for REGEXP implementation and
this fact is not concerned with GLOB removal somehow. Secondly the idea
of removing GLOB appeared in light of collations in LIKE & in light of absence
of GLOB in most of other DBMSs.