[tarantool-patches] [PATCH v1 0/3] sql: dissallow bindings for DDL

Kirill Shcherbatov kshcherbatov at tarantool.org
Fri Aug 31 18:45:39 MSK 2018


Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3653-no-bindings-on-ddl
Issue: https://github.com/tarantool/tarantool/issues/3653

Bindings could not be used in stored ACTs because they allocate
memory registers and makes assignments on parse sequentially.
Original sqlite3 did validations that persistent AST doesn't have
auto-assigment Varibles on triggers and checks creation.
On DDL integration complete we've get rid this mechanism.
Now it should be returned.
Also fixed memory leak on error in sql_*_compile functions and
double free with sql_check_list_item_init.

Kirill Shcherbatov (3):
  sql: fix sql_check_list_item_init double free
  sql: fix sql_*_compile functions leak on error
  sql: dissallow bindings for DDL

 src/box/space_def.c         |  3 ++-
 src/box/sql.c               |  5 ++---
 src/box/sql/parse.y         |  6 +++++-
 src/box/sql/prepare.c       |  1 -
 src/box/sql/tokenize.c      |  9 ++++-----
 test/sql-tap/check.test.lua |  4 ++--
 test/sql/checks.result      | 45 ++++++++++++++++++++++++++++++++++++++++++++-
 test/sql/checks.test.lua    | 18 +++++++++++++++++-
 8 files changed, 76 insertions(+), 15 deletions(-)

-- 
2.7.4





More information about the Tarantool-patches mailing list