[tarantool-patches] Re: [PATCH v1 1/1] sql: triggers on view unfinished updates

n.pettik korablev at tarantool.org
Thu Aug 16 16:45:09 MSK 2018


> Excepting primary index is a typical thing for view so

Nitpicking: not ‘excepting’ but lack of I guess.

> we should use space_index instead of index_find that doesn't
> setup diag error when no index is finded.
> 
> Closes #3536.
> ---
> diff --git a/test/sql/triggers.test.lua b/test/sql/triggers.test.lua
> index 8fd385c..fff58e9 100644
> --- a/test/sql/triggers.test.lua
> +++ b/test/sql/triggers.test.lua
> @@ -142,3 +142,17 @@ box.sql.execute("SELECT * FROM test2")
> box.sql.execute("ROLLBACK;")
> box.sql.execute("DROP TABLE test;")
> box.sql.execute("DROP TABLE test2;")
> +
> +--
> +-- gh-3536: Some triggers cause error messages and/or half-finished updates
> +--
> +box.cfg{}

Why do you need to call box.cfg{} here?



More information about the Tarantool-patches mailing list