[PATCH v2 1/7] vinyl: do not store meta in secondary index runs

[Vladimir Davydov]

Currenlty, tuple meta is only needed for storing statement flags in run
files. In the scope of #2129 two statement flags will be introduced,
VY_STMT_SKIP_READ and VY_STMT_DEFERRED_DELETE. None of them makes any
sense for secondary indexes. If we encode meta for secondary index
statements, we will have to either clear the flags on the upper level
(e.g. in the write iterator) or filter them out before encoding a
statement. Alternatively, we can skip encoding meta for secondary index
statements altogether, and this is what this patch does, because it's
the simplest and clearest method for now. If tuple meta is ever used for
storing anything else besides statement flags or a new statement flag
appears that may be used with secondary index statements, we will
recover the code and mask out those flags for secondary indexes.
---
 src/box/vy_stmt.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/box/vy_stmt.c b/src/box/vy_stmt.c
index d6ebee80..37da282d 100644
--- a/src/box/vy_stmt.c
+++ b/src/box/vy_stmt.c
@@ -615,8 +615,11 @@ vy_stmt_encode_secondary(const struct tuple *value,
 		request.key = extracted;
 		request.key_end = extracted + size;
 	}
-	if (vy_stmt_meta_encode(value, &request) != 0)
-		return -1;
+	/*
+	 * Note, all flags used with vinyl statements make sense
+	 * only for primary indexes so we do not encode meta for
+	 * secondary index statements.
+	 */
 	xrow->bodycnt = xrow_encode_dml(&request, xrow->body);
 	if (xrow->bodycnt < 0)
 		return -1;
-- 
2.11.0