[tarantool-patches] [PATCH v2] test: add test to check log_nonblock mode

Olga Arkhangelskaia krishtal.olja at gmail.com
Tue Aug 14 10:49:54 MSK 2018


We should test log_nonblock mode. In some cases the loss of this flag
lead to tarantool hanging forever. This tests checks such possibility.

gh-3615 loss of nonblock flag in logger
---
https://github.com/tarantool/tarantool/issues/3615
https://github.com/tarantool/tarantool/tree/OKriw/gh-3615-test-for-hanging-1.10

v1:
https://www.freelists.org/post/tarantool-patches/PATCH-boxtap-add-test-to-check-log-nonblock-mode

Changes in v2:
- now we fill socket with 1M of data

 test/box-tap/cfg.test.lua | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua
index 45b645630..d31936d9a 100755
--- a/test/box-tap/cfg.test.lua
+++ b/test/box-tap/cfg.test.lua
@@ -6,7 +6,7 @@ local socket = require('socket')
 local fio = require('fio')
 local uuid = require('uuid')
 local msgpack = require('msgpack')
-test:plan(95)
+test:plan(96)
 
 --------------------------------------------------------------------------------
 -- Invalid values
@@ -530,5 +530,28 @@ os.exit(res)
 ]]
 test:is(run_script(code), 0, "remote syslog log configuration")
 
+--
+-- gh-3615: check that log_nonblock is not lost
+--
+code=[[
+local socket = require('socket')
+local log = require('log')
+local fio = require('fio')
+
+path = fio.pathjoin(fio.cwd(), 'log_unix_socket_test.sock')
+unix_socket = socket('AF_UNIX', 'SOCK_DGRAM', 0)
+unix_socket:bind('unix/', path)
+
+opt = string.format("syslog:server=unix:%s,identity=tarantool", path)
+box.cfg{log = opt, log_nonblock=true}
+-- Try to fill buffer
+for i = 1, 1000 do log.info(string.rep('x', 1000)) end
+
+unix_socket:close()
+os.remove(path)
+os.exit(0)
+]]
+test:is(run_script(code), 0, "log_nonblock")
+
 test:check()
 os.exit(0)
-- 
2.14.3 (Apple Git-98)





More information about the Tarantool-patches mailing list