[tarantool-patches] Re: [PATCH v1 1/1] sql: fix segfault with check referencing new table

[n.pettik]

> Starting with 9a54320 on tuple insertion in _space we

Starting from.

> make sql_checks_resolve_space_def_reference for checks

Not make, but execute I guess. 

> if any. During executing on_replace_dd_space trigger
> box_space_id_by_name that takes a look to _space space
> returnes not-nullable value, but the same time space

Typos: at the same time, returns, non-nullable
(but I guess not-null is likely to be more suitable).

> object doesn't present in space chache and could not be

Typos: isn't presented, cache, can’t be found by. 

> found with space_by_id.
> Before 1.10 path 0ecabde merged to 2.0 as a part of 13df2b1

Typo: patch, was merged.

> box_space_id_by_name returned BOX_ID_NIL because of

Used to return, due to.

> "multi-engine transaction error" that is not rased in same

Typo: is not raised.

> situation now.
> 
> diff --git a/test/sql/checks.test.lua b/test/sql/checks.test.lua
> index 7ff78fe..bbd6747 100644
> --- a/test/sql/checks.test.lua
> +++ b/test/sql/checks.test.lua
> @@ -43,4 +43,8 @@ format = {{name = 'X', type = 'unsigned'}}
> t = {513, 1, 'test', 'memtx', 0, opts, format}
> s = box.space._space:insert(t)
> 
> +

It would be better if you put reference to issue here
(sort of gh-xxxx: short description).

> +box.sql.execute("CREATE TABLE w2 (s1 INT PRIMARY KEY, CHECK ((SELECT COUNT(*) FROM w2) = 0));")
> +box.sql.execute("DROP TABLE w2;")
> +
> test_run:cmd("clear filter")
> --