[tarantool-patches] Re: [PATCH v3] sql: remove support of partial indexes

Alexander Turenko alexander.turenko at tarantool.org
Wed Apr 25 12:22:56 MSK 2018


Hi Gleb!

Firstly, don't add autogenerated files like parse.c under version
control.

Add a person you want to respond you into 'To' header and others
(including mailing list) in 'Cc'. Just sending a message to the mailing
list doesn't trigger any review processes.

Send a message with open email to allow direct reply you (not through
mailing list). Here your email is shown as dmarc-noreply at freelists.org.

Please, fix the patch and ask me for review again.

WBR, Alexander Turenko.

On Tue, Apr 24, 2018 at 09:39:07PM +0300, Gleb wrote:
> Remove support of partial indexes.
> Add test which checks inaccessibility of partial index syntax.
> Delete usage of partial index from tests.
> They can be enabled after #2626.
> 
> Fixes #2165
> ---
> Issue from https://github.com/tarantool/tarantool/issues/2165.
> Source from https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes.
> Changes in v3:
>  -return tests which use partial.
>  -delete "WHERE" from returned tests.
>  -correct syntax errors in commit




More information about the Tarantool-patches mailing list